Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Jun 20, 2023

Description of Changes

  • SendGrid environment variables can now be configured in dev. By setting the environment variables in a .env file you can override these variables without checking them into source control.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@jdetter jdetter requested a review from cloutiertyler June 20, 2023 15:53
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@jdetter
Copy link
Collaborator Author

jdetter commented Jun 22, 2023

We are merging this with the intention of replacing this later with something more generic (so that you could use whatever backend you want)

Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
@jdetter jdetter enabled auto-merge (squash) June 22, 2023 16:13
@cloutiertyler cloutiertyler disabled auto-merge June 22, 2023 21:58
@cloutiertyler cloutiertyler merged commit cf3215d into master Jun 22, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Boppy <no-reply@boppygames.gg>
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Boppy <no-reply@boppygames.gg>
@cloutiertyler cloutiertyler deleted the jdetter/sendgrid-environment-variables branch August 1, 2023 21:54
bfops pushed a commit that referenced this pull request Jul 17, 2025
Add sslEnabled option to Connect function
bfops pushed a commit that referenced this pull request Aug 7, 2025
Add sslEnabled option to Connect function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants