Skip to content

Comments

CI - Hackily fix V8 linker errors#3921

Merged
bfops merged 3 commits intomasterfrom
bfops/fix-b8-build
Dec 19, 2025
Merged

CI - Hackily fix V8 linker errors#3921
bfops merged 3 commits intomasterfrom
bfops/fix-b8-build

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Dec 19, 2025

Description of Changes

Introduce a hacky workaround to our csharp-testsuite to address missing librusty_v8.a: manually check for that file and manually build the package if it's missing.

API and ABI breaking changes

CI-only change

Expected complexity level and risk

1

Testing

  • Locally tested removing the librusty_v8.a and then running cargo clean -p v8 && cargo build -p v8, and this does seem to repair it.
  • The CI has run with a cache that is "broken", but successfully passes csharp-testsuite

@bfops bfops requested a review from jdetter December 19, 2025 21:17
@bfops bfops marked this pull request as ready for review December 19, 2025 21:17
@bfops bfops changed the title CI - Fix V8 linker errors CI - Hackily fix V8 linker errors Dec 19, 2025
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright let's give it a try 🤷

@bfops bfops added this pull request to the merge queue Dec 19, 2025
Merged via the queue into master with commit 264e45e Dec 19, 2025
61 of 62 checks passed
@bfops bfops mentioned this pull request Jan 13, 2026
1 task
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
# Description of Changes

See #3921 for a
previous version of this PR. Just expanding that hacky fix.

# API and ABI breaking changes

CI-only change.

# Expected complexity level and risk

1

# Testing

- [x] Build fixed in
#3980

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
kistz pushed a commit to kistz/SpacetimeDB that referenced this pull request Jan 13, 2026
# Description of Changes

See clockworklabs#3921 for a
previous version of this PR. Just expanding that hacky fix.

# API and ABI breaking changes

CI-only change.

# Expected complexity level and risk

1

# Testing

- [x] Build fixed in
clockworklabs#3980

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants