Make /v1/database/:name/call/:func call procedures too, remove procedure route

[mamcx]

Description of Changes

Closes #3659

API and ABI breaking changes

Remove route and alter the semantics of the call route on both server and cli

Expected complexity level and risk

1

Testing

• Publish module with procedures and observe calling the cli the result is print.

[gefjon]

Code looks good. I tested locally and was able to call procedures. I'd like to see a smoketest added, please - something trivial that just calls a procedure and inspects its return value.

[bfops]

It sounds like this is an API break - does that mean that older versions of the CLI will not be able to spacetime call to versions of the server that have this PR included?

[gefjon]

It sounds like this is an API break - does that mean that older versions of the CLI will not be able to spacetime call to versions of the server that have this PR included?

I don't think that's true. When calling reducers, the return format of the route is unchanged, to the best of my ability to determine. It's only when calling a procedure that the route returns something different, and the old CLI won't do that because it checks the moduledef first.

[bfops]

It sounds like this is an API break - does that mean that older versions of the CLI will not be able to spacetime call to versions of the server that have this PR included?

I don't think that's true. When calling reducers, the return format of the route is unchanged, to the best of my ability to determine. It's only when calling a procedure that the route returns something different, and the old CLI won't do that because it checks the moduledef first.

Okay, great. I was just going off of this description:

Remove route and alter the semantics of the call route on both server and cli
And I assume the old route was unstable so it's fine to remove.

[jdetter]

Optional nits, seems fine to me. I have not manually tested this but it looks like we've added some smoketests so I'm happy with that 👍