Skip to content

Comments

CI - Use rust-toolchain-file everywhere#3872

Merged
bfops merged 3 commits intomasterfrom
bfops/ci-rust-toolchain
Dec 11, 2025
Merged

CI - Use rust-toolchain-file everywhere#3872
bfops merged 3 commits intomasterfrom
bfops/ci-rust-toolchain

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Dec 11, 2025

Description of Changes

We were using rust-toolchain in some places, and rust-toolchain-file in others. I think Rust released a new version, which made the rust-toolchain parts break with:

info: downloading component 'rustfmt'
info: removing previous version of component 'rust-src'
info: rolling back changes
error: could not rename component file from '/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/term/terminfo/searcher' to '/root/.rustup/tmp/a4eo07uz83vsyfhk_dir/bk': Invalid cross-device link (os error 18)
Error: Process completed with exit code 1.

(Separately, this breakage is confusing.. we'll probably run into this again when we roll forward our rust version..)

API and ABI breaking changes

None. CI-only change.

Expected complexity level and risk

1

Testing

  • CI passes
  • There are no more instances of rust-toolchain:
$ grep -rIP 'rust-toolchain(?!-file)' .github/workflows
.github/CODEOWNERS:/rust-toolchain.toml @cloutiertyler

(on master, this finds the instances we changed)

@bfops bfops requested a review from jdetter December 11, 2025 17:26
@bfops bfops enabled auto-merge December 11, 2025 18:25
@bfops bfops added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@bfops bfops added this pull request to the merge queue Dec 11, 2025
Merged via the queue into master with commit 8967ea7 Dec 11, 2025
41 of 47 checks passed
@bfops bfops deleted the bfops/ci-rust-toolchain branch December 11, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants