Skip to content

Handle unknown transactions without erroring. #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdt merged 2 commits into from
Dec 9, 2025
Merged

Handle unknown transactions without erroring. #3858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e2bdaa
Handle unknown transactions without erroring.
jsdt Dec 9, 2025
889f5f7
Merge branch 'master' into jsdt/handle-unknown-transaction
jsdt Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions crates/bindings-typescript/src/sdk/db_connection_impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import type {
ReducersView,
SetReducerFlags,
SubscriptionEventCallback,
UntypedReducerDef,
} from './reducers.ts';
import type { ClientDbView } from './db_view.ts';
import type { UntypedTableDef } from '../lib/table.ts';
Expand Down Expand Up @@ -749,20 +750,22 @@ export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
}
case 'TransactionUpdate': {
let reducerInfo = message.reducerInfo;
let unknownTransaction = false;
let reducerArgs: InferTypeOfRow<typeof reducer.params> | undefined;
const reducer = this.#remoteModule.reducers.find(
t => t.name === reducerInfo!.reducerName
)!;
if (!reducerInfo) {
unknownTransaction = true;
} else {
// TODO: performance

const reducer: UntypedReducerDef | undefined =
reducerInfo === undefined
? undefined
: this.#remoteModule.reducers.find(
t => t.name === reducerInfo!.reducerName
);
let reducerArgs: UntypedReducerDef['params'] | undefined = undefined;

let unknownTransaction = reducer === undefined;
if (reducer) {
try {
const reader = new BinaryReader(reducerInfo.args as Uint8Array);
const reader = new BinaryReader(reducerInfo!.args as Uint8Array);
reducerArgs = ProductType.deserializeValue(
reader,
reducer?.paramsType
reducer.paramsType
);
} catch {
// This should only be printed in development, since it's
Expand All @@ -786,7 +789,6 @@ export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
}
return;
}

// At this point, we know that `reducerInfo` is not null because
// we return if `unknownTransaction` is true.
reducerInfo = reducerInfo!;
Expand All @@ -808,7 +810,7 @@ export class DbConnectionImpl<RemoteModule extends UntypedRemoteModule>
tag: 'Reducer',
value: reducerEvent,
};
const eventContext = this.#makeEventContext(event);
const eventContext = this.#makeEventContext(event as any);
const reducerEventContext = {
...eventContext,
event: reducerEvent,
Expand Down