C# Views - Use Name from ViewAttribute instead of Method Name

[chutch1122]

C# Views - Use Name from ViewAttribute instead of Method Name

Description of Changes

The documentation for C# views says that "Views must be declared as Public, with an explicit Name, and [...]". However, the Name provided to the View attribute is not being used as the name of the view in the Module or the generated C# client SDK code. The ViewDeclaration actually checks that the View attribute's name is not null or empty, but then proceeds to do nothing with it.

This PR updates the ViewDeclaration to use the Name property from ViewAttribute.

For more info - see my bug report in Discord: https://discord.com/channels/1037340874172014652/1443881580602069043

API and ABI breaking changes

No breaking change to the API. Though, anyone who has a view name declared that's different from their method name will have to deal with that during migration of their modules.

Expected complexity level and risk

1 - Trivial change

Testing

I compiled the C# projects under crates/bindings-csharp, built the NuGet packages, and tested them locally with a project using SpacetimeDB 1.10 (CLI and associated packages).

I confirmed that the generated classes now use the value from the View attribute as the RemoteTableName. See attached image.

[CLAassistant]

All committers have signed the CLA.

[bfops]

Thank you for creating this! We'll work on getting it reviewed.

[rekhoff]

Good find, changes are very strait forward. I've updated the Snapshots to reflect the change. Approved