Don't panic in datastore_index_scan_range_bsatn on invalid ranges#3746
Merged
Don't panic in datastore_index_scan_range_bsatn on invalid ranges#3746
datastore_index_scan_range_bsatn on invalid ranges#3746Conversation
Centril
force-pushed
the
centril/deps-house-keeping
branch
2 times, most recently
from
3d6a7fe to
cb56bdc
Compare
Centril
force-pushed
the
centril/seek-range-on-invalid-ranges
branch
from
0c5aee4 to
d47b085
Compare
Centril
force-pushed
the
centril/seek-range-on-invalid-ranges
branch
from
d47b085 to
9bf46b1
Compare
bfops
added
release-any
joshua-spacetime
approved these changes
Dec 5, 2025
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
We've gone with sql semantics which is to say that an empty range returns an empty set instead of returning an error which is reasonable. No objections.
gefjon
approved these changes
Dec 8, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I looked at this a while ago, and I thought I approved it then. Oops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #3617.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
A proptest
empty_range_scans_dont_panicis added.