Merged
Conversation
gefjon
approved these changes
Nov 24, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Needs review from @Centril and/or @cloutiertyler for their context on V8 internals and TypeScript bindings, but looks reasonable to me. API matches the one in Rust.
Centril
approved these changes
Nov 24, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Looks good to me. I'm comfortable with also approving the TS parts here.
coolreader18
force-pushed
the
noa/ts-transactions
branch
2 times, most recently
from
d575b50 to
a986589
Compare
coolreader18
force-pushed
the
noa/ts-transactions
branch
from
a986589 to
22daade
Compare
coolreader18
force-pushed
the
noa/ts-transactions
branch
from
22daade to
cdfb666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Mirrors the Rust API.
Expected complexity level and risk
2
Testing
sdks/rust/tests)