Merged
Conversation
bfops
approved these changes
Nov 20, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
LGTM. I think it would be fine to leave the other variants on a single line, but I don't feel strongly one way or another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ubuntu-latestrecently changed to 24.04 instead of 22.04 so that broke the last CLI on some systems. This will fix that issue.API and ABI breaking changes
None
Expected complexity level and risk
2 - if the CLI fails to build this might be why.
Testing