Skip to content

Comments

Fix #3687#3692

Merged
jdetter merged 13 commits intomasterfrom
bfops/run-dotnet-format
Nov 19, 2025
Merged

Fix #3687#3692
jdetter merged 13 commits intomasterfrom
bfops/run-dotnet-format

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Nov 18, 2025

Description of Changes

Apparently, when spacetime generate passes files to a linter, the files are passed in as relative paths, which did not play properly with dotnet format (so we effectively borked it).

API and ABI breaking changes

None.

Expected complexity level and risk

1

Testing

  • Unity testsuite no longer fails on expected diffs

@bfops bfops marked this pull request as ready for review November 19, 2025 00:19
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - haven't tested it myself but it fixes the CI

@jdetter jdetter enabled auto-merge November 19, 2025 05:04
@jdetter jdetter added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit 47ac2b9 Nov 19, 2025
26 checks passed
@bfops bfops deleted the bfops/run-dotnet-format branch November 19, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants