commitlog: Change default max-records-in-commit to 1#3681
Merged
Conversation
It is almost always wrong / undesirable to pack more than one transaction in a commit, so adjust the default accordingly. This also avoids surprises when using `#[serde(default)]` with nested structs -- serde evaluates the default depth-first, so overriding a single field in a nested struct will not consider any `#[serde(default = "custom_default")]` annotations on the parent.
Shubham8287
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is almost always wrong / undesirable to pack more than one
transaction in a commit, so adjust the default accordingly.
This also avoids surprises when using
#[serde(default)]with nestedstructs -- serde evaluates the default depth-first, so overriding a
single field in a nested struct will not consider any
#[serde(default = "custom_default")]annotations on the parent.