Skip to content

CI - Cancel internal tests if cancelled #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bfops merged 42 commits into from
Nov 17, 2025
Merged

CI - Cancel internal tests if cancelled #3674

bfops merged 42 commits into from
Nov 17, 2025

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Nov 17, 2025 •
edited
Loading

Description of Changes

Internal Tests invoke another workflow. If the calling workflow is cancelled, now we also cancel the invoked workflow.

API and ABI breaking changes

None.

Expected complexity level and risk

2

Testing

  • Push multiple commits to this PR, see that the invoked job is cancelled
  • Manually cancel the Internal Tests job, see that the invoked job is cancelled

jdetter added 30 commits November 13, 2025 00:11
@jdetter
Use new runner for testsuite
d3dc60f
@jdetter
Run job in container
8f0e79d
@jdetter
Use custom container
eefdd0b
@jdetter
Use local container
71980d3
@jdetter
updated workflow
3d22d05
@jdetter
Fix run for fallocate test
62a4f7e
@jdetter
Run smoketests on the custom runner
ac437f8
@jdetter
Rerun CI
fa624f9 
Updated

Runner fix

Don't install dotnet in the container for smoketests

Rerun

Use container settings

Rerun again

Try again

Yet another run

Dont use runner user

Try again

Test ephemeral runners
@jdetter
Potential fix
7ba5a74 
Another CI run

Remove comment

Concurrency test

Concurrency test 2

concurrency test 3

Test

test 2

Attempt fix

Add more jobs to the new runner

Use container

Remove a small diff

Another diff fix

Enable cancel in progress
@jdetter
One-liner
d50a347
@jdetter
Indenting fix
9e92535
@jdetter
Use docker in docker
4cd95dc
@jdetter
Fix copy/paste issue
29b0859
@jdetter
Add debug step
b8769b7
@jdetter
Remove debug
5112401
@jdetter
Few docker updates
6ef59eb
@jdetter
Let's give the unreal engine testsuite a try
325901f
@jdetter
Fix
14a2f1f
@jdetter
Let's try the Unity tests as well
4ec0cfe
@jdetter
Try unity testsuite again
04b25fa
@jdetter
Use start docker so that the testsuite can access docker
27bb5c0
@jdetter
Rebuild
84e344e
@jdetter
Rebuild again
5458647
@jdetter
Use cargo home instead
96090a0
@jdetter
Fix cgroups error
c3faf0c
@jdetter
Remove debug
bb2462e
@jdetter
All tests are passing
4d33efd
@jdetter
Merge branch 'master' into jdetter/use-new-runner
c96eeef
@jdetter
Try sequential testing for UnrealEngine
8384f9a
@jdetter
Merge remote-tracking branch 'origin/jdetter/use-new-runner' into jde…
2ddb8a1 
…tter/use-new-runner
@bfops bfops requested a review from jdetter November 17, 2025 19:00
@bfops bfops marked this pull request as ready for review November 17, 2025 19:00
jdetter
jdetter reviewed Nov 17, 2025
View reviewed changes
jdetter
jdetter reviewed Nov 17, 2025
View reviewed changes
jdetter
jdetter approved these changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested myself but this looks great, thanks Zeke 🙏

@bfops bfops enabled auto-merge November 17, 2025 19:55
@bfops bfops changed the base branch from master to jdetter/use-new-runner November 17, 2025 20:35
@bfops bfops changed the base branch from jdetter/use-new-runner to master November 17, 2025 20:36
@bfops bfops added this pull request to the merge queue Nov 17, 2025
Merged via the queue into master with commit ee69be7 Nov 17, 2025
45 of 50 checks passed
@bfops bfops linked an issue Nov 18, 2025 that may be closed by this pull request
Cancel Internal Tests private job if the public job is cancelled #3655
Closed
@bfops bfops deleted the bfops/cancel-internal-tests branch November 19, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdetter jdetter jdetter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cancel Internal Tests private job if the public job is cancelled

3 participants

@bfops @jdetter