Conversation
d54b8b9 to
62a4f7e
Compare
c80af6b to
ac437f8
Compare
9e5a16d to
f532af7
Compare
Another CI run Remove comment Concurrency test Concurrency test 2 concurrency test 3 Test test 2 Attempt fix Add more jobs to the new runner Use container Remove a small diff Another diff fix Enable cancel in progress
b8b82f5 to
7ba5a74
Compare
jdetter
commented
Nov 14, 2025
8b6c3ac to
ca96586
Compare
jdetter
commented
Nov 14, 2025
…tter/use-new-runner
ca96586 to
2ddb8a1
Compare
jdetter
commented
Nov 14, 2025
bfops
reviewed
Nov 17, 2025
bfops
approved these changes
Nov 17, 2025
Collaborator
bfops
left a comment
There was a problem hiding this comment.
this LGTM, though I worry about you being the only person who understands these changes. If something went wrong, I wouldn't know how to debug it.
bfops
reviewed
Nov 17, 2025
1 task
de5c553 to
7213e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Speed improvements:
CI/Unreal Engine - switch to serial test execution
CI/Testsuite - partially switch to serial test execution
I also haven't seen an unexpected
Operation cancelled, so I think that problem might be behind us.API and ABI breaking changes
No user facing changes
Expected complexity level and risk
2 - this touches a lot of our CI. It has been solid so far but if we start getting random CI failures this could be the cause.
Testing
(ok as of this update the internal tests are failing but that isn't related to this PR 😅 )
Future Work
There are 2 remaining tests that could be optimized by moving them to faster runners:
I would also consider moving from instantiating container images to instantiating VM snapshots. This would allow us a lot more flexibility and we wouldn't have to have as much container config in our workflow files. Based on guides I've seen online this is also somewhat common. Also managing docker within docker has been kind of a nightmare so it would be easier to run containers inside of VMs to remove a layer of containerization there.
Testsuite inconsistencies
We have at least 2 different jobs that are inconsistent/flaky: the "testsuite" and the "unreal engine tests".
I'd like @JasonAtClockwork to make the unreal engine tests run sequentially so that we have less random failures. I know this will increase the testing time but due to this PR we should have extra headroom there.
I've also pinged Joshua about one of the tests that I've seen sometimes fails randomly. This is either an issue in the test or an issue in SpacetimeDB itself, I'm not sure yet.
These inconsistencies are present both in our custom runner and in the Github runners, so merging this PR will not make this situation any worse than it already is.