[TS] Implement basic procedure calling#3649
Merged
coolreader18 merged 3 commits intomasterfrom Nov 24, 2025
Merged
Conversation
coolreader18
force-pushed
the
noa/ts-procedures
branch
from
845d892 to
f03b4db
Compare
Centril
reviewed
Nov 17, 2025
coolreader18
force-pushed
the
noa/ts-procedures
branch
3 times, most recently
from
ffd7bc9 to
a532856
Compare
This was
linked to
issues
Nov 20, 2025
Closed
coolreader18
force-pushed
the
noa/ts-procedures
branch
4 times, most recently
from
4cda075 to
acd46ea
Compare
Centril
approved these changes
Nov 24, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
This looks good to me, and thanks for refactoring into InstanceEnv. I haven't reviewed the changes to .ts files that deeply though.
cloutiertyler
approved these changes
Nov 24, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This seems fine to me. Note for posterity that the withTx API is to be added in a future PR.
coolreader18
force-pushed
the
noa/ts-procedures
branch
from
acd46ea to
6e2ece6
Compare
Collaborator
|
The C#/Unity test failure here is a known problem in master, the PR that introduced that issue is being reverted so feel free to ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Implements
__call_procedure__in the TS bindings and host.Expected complexity level and risk
2
Testing