Update views on auto-migrate#3631
Merged
joshua-spacetime merged 5 commits intomasterfrom Nov 12, 2025
Merged
Conversation
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Nice refactoring and even nicer tests!
Shubham8287
force-pushed
the
shub/view-auto-migration
branch
from
b9b6d27 to
51da2df
Compare
Shubham8287
force-pushed
the
shub/view-auto-migration
branch
from
51da2df to
cc63327
Compare
joshua-spacetime
approved these changes
Nov 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improves auto-migration support for views by minimizing the cases where we must disconnect clients.
Before this patch, any schema compatible view update and even no view updates at all would require us to disconnect clients, because we had to assume that the view was modified thereby rendering its currently materialized result set stale and out of date.
Patch adds a code to re-evaluate all views whose entry is in
st_view_suband makeupdate_databaseto start usingcommit_and_broadcast_eventso that now we only have to disconnect clients for incompatible view updates or dropped views.API and ABI breaking changes
NA
Expected complexity level and risk
2
Testing
Added smoketests.