Materialize views for subscriptions #3599
Open
+526
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
from
0e43a96 to
8168623
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
from
97436d2 to
028782f
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
from
8168623 to
b0a6942
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
from
028782f to
664577c
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-query
branch
from
3c5530b to
eadfc38
Compare
Centril
reviewed
Nov 7, 2025
Comment on lines
811
to
812
| let mut_tx = ScopeGuard::<MutTxId, _>::into_inner(mut_tx); | ||
| let (tx, tx_offset) = self.materialize_views_and_downgrade_tx(mut_tx, &queries, auth.caller)?; |
Contributor
There was a problem hiding this comment.
Would be good to explain why we are doing this in the code.
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
3 times, most recently
from
e1d6e16 to
f2af6fe
Compare
joshua-spacetime
changed the base branch from
joshua/update-st-view-sub-on-query
to
master
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
from
f2af6fe to
223dc20
Compare
Shubham8287
reviewed
Nov 7, 2025
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
from
fa7a28c to
3383fd5
Compare
joshua-spacetime
force-pushed
the
joshua/update-st-view-sub-on-subscribe
branch
from
3383fd5 to
2c86ee8
Compare
Shubham8287
approved these changes
Nov 8, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
LGTM,we should also do the code cleanup to remove module_rx field from ModuleSubscription as we decided to not go with that (works in next PR too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch:
call_viewon theModuleHost.st_view_subsystem table on both subscribe and unsubscribe.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
TODO