Fix for multi-column indexes in typescript modules #3589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Nov 6, 2025
Collaborator
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
I was hoping to avoid recursion, but if it doesn't work otherwise, this LGTM
cloutiertyler
approved these changes
Nov 6, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This makes sense and looks good to me
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This updates a bunch of types to make sure we generate the right functions for indexes with multiple columns. Most of the changes are making the array of column names readonly.
This also has a fix for
AllUnique, because we were treating composite indexes as unique when the first field had a unique index. FWIW, we should also make sure that the range scanning functions still exist in that case, but I didn't try to add that here.API and ABI breaking changes
Any change to these types is probably technically a breaking API change, but no one should consider these types stable.
Expected complexity level and risk
1.5. I'm still not super confident with some of these types, but this shouldn't change any runtime behavior.
Testing
I added some uses of indexes in
schema.test-d.ts, sopnpm run build:typeswould throw errors if this were broken.