Treat a missing aud claim as an empty list #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
approved these changes
Oct 30, 2025
cloutiertyler
approved these changes
Oct 31, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
These changes look good to me.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
# Description of Changes This adds some code samples for using auth claims in Rust, Typescript, and C#. Much of this was originally in #3218. # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> # Expected complexity level and risk 1: this is a docs-only change. # Testing I've tested these code samples locally (with the changes in #3542). --------- Signed-off-by: Jeffrey Dallatezza <jeffreydallatezza@gmail.com> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The
audclaim is required in the OIDC spec, but the server currently allows it to be missing, and the spacetime auth tokens we use for the website don't have an audience.Previously the module bindings would throw an error if there were no
audclaim in a jwt payload (if someone used theaudiencewithin a reducer), but this change makes us treat a missing audience as an empty list.This also renames the
authCtxfields tosenderAuthin the typescript and csharp module APIs, so they match rust.API and ABI breaking changes
This doesn't break any ABIs.
This changes the ReducerContext APIs in typescript and rust, but only by renaming a field that hasn't been released yet.
Expected complexity level and risk
Testing
I've tested accessing the
audiencewithin a reducer for a token missing anaudclaim in Typescript and Rust.