fix migration which adds column and index together.#3450
Merged
Shubham8287 merged 4 commits intomasterfrom Oct 23, 2025
Merged
Conversation
Centril
approved these changes
Oct 22, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Approved with requested commentary added.
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
auto_migrate_databaseshould not take table schema as input because each step is ordered and may depend on changes made by a prior step, this approach can lead to incorrect assumptions (e.g., adding a column changes its table id).Migration steps now retrieve the current table schema when they run. This adds a small performance cost, but it simplifies the logic and code is not under hotpath.
fixes #3441
API and ABI breaking changes
NA
Expected complexity level and risk
1
Testing
Update smoketest to add failed case.