add rust-src to the toolchain and update trybuild test output #3440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
approved these changes
Oct 21, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Thanks for the updated description. This now LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds
rust-srcto the toolchain and updates the expected output of thetrybuildtests.rust-srcplaces the entire source code of the rust stdlib under the local toolchain directory.rust-analyzeruses it for "go to definition" (among other things) in the stdlib. When included in the toolchain, rustc can provide code frames that it can't otherwise.The reason for its addition is that if anyone includes it in their local toolchain, the error messages produced by rustc when running the
uitests will be slightly different (have some more information) than when run in CI. Hence those tests will fail locally but not in CI. Rather than removingrust-srclocally so that the tests will pass, I've opted to just add it to the toolchain so that everyone runs with it by default, including in CI.API and ABI breaking changes
None
Expected complexity level and risk
0
Testing