Fix bootstrapping of ST_MODULE #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Sep 29, 2023
cloutiertyler
approved these changes
Sep 29, 2023
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Approved as a temporary fix until this is properly fixed in #267
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes This is a fix for community bug clockworklabs/com.clockworklabs.spacetimedbsdk#340 that was the result of changes to SpacetimeDBClient code that missed changes to the WebGL build. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs - None ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Tested changes against Blackholio running under a Unity WebGL build
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes This is a fix for community bug clockworklabs/com.clockworklabs.spacetimedbsdk#340 that was the result of changes to SpacetimeDBClient code that missed changes to the WebGL build. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs - None ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Tested changes against Blackholio running under a Unity WebGL build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
System tables are inserted into the committed state lazily, but since ST_MODULE (introduced in #290) is not referenced by other system tables, it won't. Interestingly, this only surfaces in tests written for #289.
This is mostly a quick fix, hoping #267 will generalize bootstrapping enough to cover this case.
API and ABI
If the API is breaking, please state below what will break