Fix windows linker errors #3416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekhoff
approved these changes
Oct 16, 2025
Contributor
There was a problem hiding this comment.
Tested the following:
cargo build - Passed
cargo run -p spacetimedb-standalone - Passed
cargo run -p spacetimedb-cli - Passed
cargo run -p spacetimedb-update - Passed
Currently not all tests pass when cargo test is ran, but they seem to fail at test cli::self_install::tests::ensure_script_help_is_up_to_date which is part of the cargo test -p spacetimedb-update test. I've confirmed this was still failing at 1.4.0's release on both my Windows system, so shouldn't be a blocker here. Just a note for the future. (Recorded the issue in #3420)
With the above tests and the CI testing passing, I'm approving this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
My guess as to the problem was that there were static libs in the dependency graph that were wanting to statically link to libc functions, but rustc didn't know we wanted to link libc statically - so adding
+crt-staticfixes it.API and ABI breaking changes
Expected complexity level and risk
1
Testing