Merged
Conversation
Collaborator
|
The tests are failing. I think several of them just need a |
bfops
added
release-any
bfops
reviewed
Oct 24, 2025
bfops
reviewed
Oct 24, 2025
bfops
reviewed
Oct 24, 2025
bfops
reviewed
Oct 24, 2025
bfops
reviewed
Oct 24, 2025
Collaborator
|
FYI I pushed a merge commit so the CI would run again |
bfops
reviewed
Oct 29, 2025
bfops
reviewed
Nov 10, 2025
bfops
reviewed
Nov 10, 2025
bfops
reviewed
Nov 20, 2025
bfops
reviewed
Nov 24, 2025
bfops
reviewed
Dec 9, 2025
bfops
reviewed
Dec 9, 2025
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
reviewed
Dec 9, 2025
bfops
reviewed
Dec 9, 2025
bfops
reviewed
Dec 9, 2025
bfops
approved these changes
Dec 9, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
LGTM, minus a few comments
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: Roberto Pommella Alegro <robertoaall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This changes the ci runs to execute
cargo ciinstead of running commands directly from the github workflow.The goal here is to unify the commands under
cargo ciso that it's easier and more intuitive to run locallyAPI and ABI breaking changes
There are no API/ABI changes.
Expected complexity level and risk
Complexity: 1
It is not a complex change as it is mostly localized to the ci runs and is easily reversible if something goes wrong. The biggest risk here is to have future CI runs break, which can be remediated by reverting these changes.
Testing
cargo ciand its subcommands locally