Add forgotten variance to table_index::can_merge #3391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TableIndex merge logic to was missing variants.
|
|
Centril
approved these changes
Oct 9, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Code itself LGTM. Also, oops 😊
Collaborator
|
@SamuelE-Arvika are you willing to take a look at the Contributor License Agreement? (See #3391 (comment) for more info). |
Merged
via the queue into
clockworklabs:master
with commit Oct 15, 2025
3075ca4
19 of 21 checks passed
joshua-spacetime
pushed a commit
that referenced
this pull request
Oct 16, 2025
TableIndex merge logic to was missing variants. # Description of Changes This pull request fixes an issue where the TableIndex::can_merge function was missing match variants. # API and ABI breaking changes None. # Expected complexity level and risk 1 / 5 (Trivial) This is a very low-risk change. It simply adds a few lines to a match statement # Testing Manual testing confirm that creating two tables with indices with the for the missing variants no longer causes a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableIndex merge logic to was missing variants.
Description of Changes
This pull request fixes an issue where the TableIndex::can_merge function was missing match variants.
API and ABI breaking changes
None.
Expected complexity level and risk
1 / 5 (Trivial)
This is a very low-risk change. It simply adds a few lines to a match statement
Testing
Manual testing confirm that creating two tables with indices with the for the missing variants no longer causes a panic.