Fix for Unreal codegen for Optional fields #3360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonAtClockwork
added
bugfix
jdetter
reviewed
Oct 14, 2025
jdetter
approved these changes
Oct 14, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I haven't tested this myself but this looks change looks correct and the regression tests have been updated. The updated tests are passing CI. Thanks @JasonAtClockwork 👍
joshua-spacetime
pushed a commit
that referenced
this pull request
Oct 16, 2025
# Description of Changes - Fixed logic issue around Option<Vec<Option<>>> applying the wrong types for primitives and dropping Optional - Fixed an issue with enum vs enum variants wrapped in Option<> producing the incorrect Unreal type - Removed unnecessary and incorrect header bindings - Type fix in the tests around the Optional Int32 # API and ABI breaking changes No breaking changes # Expected complexity level and risk 2 - Reworked incorrect optional lookups which can happen recursively # Testing I built out a few simple and complex objects in a Rust module to triple-check possible cases beyond what the test framework calls out. - [x] Tested many combinations from a Rust module to an Unreal project - [x] Ran and updated Unreal test cases as necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
No breaking changes
Expected complexity level and risk
2 - Reworked incorrect optional lookups which can happen recursively
Testing
I built out a few simple and complex objects in a Rust module to triple-check possible cases beyond what the test framework calls out.