Skip to content

split create snapshot method #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shubham8287 merged 1 commit into from
Oct 3, 2025
Merged

split create snapshot method #3344

Shubham8287 merged 1 commit into from
Oct 3, 2025

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Oct 3, 2025 •
edited
Loading

Description of Changes

Split create_snaphot method to expose write_snapshot_file.
Required for #3344

Expected complexity level and risk

1

Testing

Exising tests

Centril
Centril approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code motion, LGTM.

@Shubham8287 Shubham8287 added this pull request to the merge queue Oct 3, 2025
Merged via the queue into master with commit 9b87337 Oct 3, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Centril Centril Centril approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shubham8287 @Centril