C# tests - update snapshots #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
reviewed
Sep 30, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I think I'd personally like to keep the new bindings and just update the snapshots - if that's a lot of work and we're confident that keeping the old bindings won't cause any issues then I'm fine to do that as well. If you want to move this one forward just ping me again and take it out of draft and I'll take another look 👍
sdks/csharp/examples~/quickstart-chat/client/module_bindings/Reducers/SendMessage.g.cs
Show resolved
Hide resolved
jdetter
approved these changes
Oct 1, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
This looks great, thanks Zeke 👍
… into bfops/fix-dotnet-test
bfops
added a commit
that referenced
this pull request
Oct 1, 2025
# Description of Changes I chose to regenerate all of the bindings in #3310, but that caused the snapshots to change. This PR follows up to update them. I also updated the outdated script `tools~/gen-quickstart-chat.sh` (which was generating from a different module than the CI was), and updated the CI to use it instead of manually running a similar command. # API and ABI breaking changes Test-only changes. # Expected complexity level and risk 1 # Testing - [x] unity-testsuite passes on this PR (which it does not on `master`). --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I chose to regenerate all of the bindings in #3310, but that caused the snapshots to change. This PR follows up to update them.
I also updated the outdated script
tools~/gen-quickstart-chat.sh(which was generating from a different module than the CI was), and updated the CI to use it instead of manually running a similar command.API and ABI breaking changes
Test-only changes.
Expected complexity level and risk
1
Testing
master).