Skip to content

Document PG wire format #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mamcx merged 2 commits into from
Oct 1, 2025
Merged

Document PG wire format #3302

mamcx merged 2 commits into from
Oct 1, 2025

Conversation

@mamcx
Copy link
Contributor

@mamcx mamcx commented Sep 29, 2025

Description of Changes

As the title says

Expected complexity level and risk

1

Testing

  • Manually create the projects shown as examples and run them

@mamcx mamcx self-assigned this Sep 29, 2025
@mamcx mamcx added documentation Improvements or additions to documentation release-next labels Sep 29, 2025
mamcx
mamcx commented Sep 29, 2025
View reviewed changes
mamcx
mamcx commented Sep 29, 2025
View reviewed changes
@bfops bfops added no runtime change This change does not affect the final binaries release-any To be landed in any release window labels Sep 29, 2025
@mamcx mamcx mentioned this pull request Sep 29, 2025
Merged
1 task
cloutiertyler
cloutiertyler reviewed Sep 29, 2025
View reviewed changes
@mamcx mamcx force-pushed the mamcx/pg-document-wire-format branch 2 times, most recently from c6cac3a to 75e0e60 Compare September 29, 2025 21:04
cloutiertyler
cloutiertyler approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's quite good, I would just like to see the comments I left addressed, but overall it works.

cloutiertyler pushed a commit that referenced this pull request Sep 29, 2025
@mamcx
Make optional to listen to pg wire protocol and param for the port (#…
ae7fee6 
…3309)

# Description of Changes

As the title says.

Add `--pg-port NUM` to the `start` command

# API and ABI breaking changes

Before this, it was set to `5432` unconditionally.

Docs updated at #3302.

# Expected complexity level and risk
1

# Testing

- [x] Run smoke tests
@mamcx mamcx force-pushed the mamcx/pg-document-wire-format branch from c1417b9 to 1f0c698 Compare October 1, 2025 14:47
@mamcx mamcx force-pushed the mamcx/pg-document-wire-format branch from 1f0c698 to 0f084d3 Compare October 1, 2025 16:26
@mamcx mamcx enabled auto-merge October 1, 2025 16:26
@mamcx mamcx added this pull request to the merge queue Oct 1, 2025
bfops added a commit that referenced this pull request Oct 1, 2025
@bfops
[docs/staging]: Manually apply open PR #3302: Document PG wire format
105ba89
Merged via the queue into master with commit be750e3 Oct 1, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

@joshua-spacetime joshua-spacetime Awaiting requested review from joshua-spacetime

Assignees

@mamcx mamcx

Labels

documentation Improvements or additions to documentation no runtime change This change does not affect the final binaries release-any To be landed in any release window release-next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mamcx @cloutiertyler @bfops