Expand scope of DurabilityProvider to include snapshotting
#3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Sep 24, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Looks great! Love the clear motivating comments.
The `DurabilityProvider` trait was introduced to enable the `HostController` to procure an alternative `Durability` impl from an external source. It is also useful to be able to instantiate a `SnapshotWorker` externally, in order to subscribe to snapshot creation events without access to the `RelationalDB` instance it is operating on. At a later stage, we may also use it to control the snapshot frequency externally. This patch thus reframes the trait as `PersistenceProvider`, whose job is to provide persistence-related services. Also separates snapshot creation and compression of older snapshots, and adds instrumentation to gather timing information for both.
kim
force-pushed
the
kim/persistence-provider
branch
from
32eb7ce to
fd79d2f
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
The `DurabilityProvider` trait was introduced to enable the `HostController` to procure an alternative `Durability` impl from an external source. It is also useful to be able to instantiate a `SnapshotWorker` externally, in order to subscribe to snapshot creation events without access to the `RelationalDB` instance it is operating on. At a later stage, we may also use it to control the snapshot frequency externally. This patch thus reframes the trait as `PersistenceProvider`, whose job is to provide persistence-related services. Also separates snapshot creation and compression of older snapshots, and adds instrumentation to gather timing information for both. # Description of Changes Re-submit of #3281 (reverted by #3293), with only the intended changes. # Expected complexity level and risk 1.5 # Testing No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DurabilityProvidertrait was introduced to enable theHostControllerto procure an alternativeDurabilityimpl from an external source.It is also useful to be able to instantiate a
SnapshotWorkerexternally, in order to subscribe to snapshot creation events without access to theRelationalDBinstance it is operating on.At a later stage, we may also use it to control the snapshot frequency externally.
This patch thus reframes the trait as
PersistenceProvider, whose job is to provide persistence-related services.Also separates snapshot creation and compression of older snapshots, and adds instrumentation to gather timing information for both.
Expected complexity level and risk
1.5
Testing
Not a functional change, existing tests should cover that.