Positional Arguments #322
Merged
Positional Arguments #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…worklabs/SpacetimeDB into jdetter/positional-arguments
jdetter
commented
Sep 26, 2023
gefjon
approved these changes
Sep 26, 2023
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
This is excellent! Made some code-cleanliness suggestions (well, one suggestion, spread across several comments, really). Once that's in, I think this is ready to merge.
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
bfops
added a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes Update DLLs to the 1.1.2 versions that have been pushed to NuGet. The SpacetimeDB tag that they were built from is `v1.1.2-csharp-release`. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs None, because we're updating the DLLs to essentially include SpacetimeDB PRs. ## Testsuite SpacetimeDB branch name: master ## Testing CI I guess? Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
bfops
added a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes Update DLLs to the 1.1.2 versions that have been pushed to NuGet. The SpacetimeDB tag that they were built from is `v1.1.2-csharp-release`. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs None, because we're updating the DLLs to essentially include SpacetimeDB PRs. ## Testsuite SpacetimeDB branch name: master ## Testing CI I guess? Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Changes the
callcommand from looking like this:spacetime call module add_names '["John", "Tyler", "Phoebe"]'To this much more managable command:
We do this by checking to see if any given argument is a string for a reducer. If it is a string, we quote it before constructing the JSON.
API and ABI
Warning: This breaks compatibility with the website tutorials and we'll need to update those before sending this update out.
If the API is breaking, please state below what will break