Fix adding enum variants #3200
Merged
Fix adding enum variants #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
reviewed
Aug 25, 2025
gefjon
reviewed
Aug 25, 2025
gefjon
approved these changes
Aug 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gefjon
pushed a commit
that referenced
this pull request
Aug 27, 2025
# Description of Changes First commit reverts disabling adding enum variants (#3178). Second commit makes replay recognize inserts / deletes to `st_column` and triggers a refresh of the in-memory table that was referenced in the `st_column` change. # API and ABI breaking changes None # Expected complexity level and risk 3, small code bug "deep". # Testing I've confirmed manually that a module that couldn't be restarted before this PR can now be restarted. We should probably follow up this PR with a smoketest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
First commit reverts disabling adding enum variants (#3178).
Second commit makes replay recognize inserts / deletes to
st_columnand triggers a refresh of the in-memory table that was referenced in thest_columnchange.API and ABI breaking changes
None
Expected complexity level and risk
3, small code bug "deep".
Testing
I've confirmed manually that a module that couldn't be restarted before this PR can now be restarted.
We should probably follow up this PR with a smoketest.