Increase default incoming_queue_length limit, log warning when a client violates it
#3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2048 turned out to be too low a value for BitCraft, as their world upload process requests on the order of 6000 reducers very rapidly. We still feel that having a limit is valuable to prevent malicious or misguided clients from taking an arbitrarily large amount of host memory, so we bump the value to give us a wide safety error for BitCraft's needs but don't remove the limit entirely.
joshua-spacetime
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #3170 .
Commit messages:
Increase the default incoming-queue-length limit
2048 turned out to be too low a value for BitCraft, as their world upload process requests on the order of 6000 reducers very rapidly. We still feel that having a limit is valuable to prevent malicious or misguided clients from taking an arbitrarily large amount of host memory, so we bump the value to give us a wide safety error for BitCraft's needs but don't remove the limit entirely.
Add log at
warnwhen the host disconnects a client due to too many requestsAPI and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing