Fix module hotswapping for connected clients #3159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Clone` impl for `ClientConnection` would create an independent instance that could not observe module hotswapping. This would result in methods called on a replaced `ModuleHost` to fail, because that host exited already. Fix by reading the `ModuleHost` from the watch channel directly, instead of maintaining a redundant copy. Also fix `watch_module_host` to properly mark the current module host as seen.
kim
force-pushed
the
kim/fix/hotswapping
branch
from
5c309bb to
14d2827
Compare
gefjon
approved these changes
Aug 13, 2025
Collaborator
|
@bfops confirmed as well this this specifically fixed the module hot-reloading issue that we were having when he retested |
bfops
pushed a commit
that referenced
this pull request
Aug 20, 2025
The `Clone` impl for `ClientConnection` would create an independent instance that could not observe module hotswapping. This would result in methods called on a replaced `ModuleHost` to fail, because that host exited already. Fix by reading the `ModuleHost` from the watch channel directly, instead of maintaining a redundant copy. Also fix `watch_module_host` to properly mark the current module host as seen. # Expected complexity level and risk 2 # Testing - [x] test suite passes - [x] ran @bfops repro script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cloneimpl forClientConnectionwould create an independentinstance that could not observe module hotswapping. This would result in
methods called on a replaced
ModuleHostto fail, because that hostexited already.
Fix by reading the
ModuleHostfrom the watch channel directly, insteadof maintaining a redundant copy.
Also fix
watch_module_hostto properly mark the current module host asseen.
Expected complexity level and risk
2
Testing