commitlog: Provide folding over a range of tx offsets #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using iterators, the consumer can decide if and when to abort the traversal. With folds, the only way would be to make the decoder return an error, which is not always convenient. Instead, allow folding over a range of transaction offsets.
kim
force-pushed
the
kim/commitlog/range-fold
branch
from
3e9c4a1 to
6e7331d
Compare
gefjon
approved these changes
Aug 7, 2025
Shubham8287
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods and free-standing functions to allow folds to stop at an upper
bound, by passing a range instead of only a start offset.
Expected complexity level and risk
1
Testing