feat(311): Make right hand side of join generic #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/311/join-rhs
branch
from
dfc9fa8 to
ad9649f
Compare
mamcx
approved these changes
Sep 21, 2023
Contributor
mamcx
left a comment
mamcx
left a comment
There was a problem hiding this comment.
LGTM. Great to get rid of that nasty hack of mine!
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
in unity tutorial text. There was confusion: https://discord.com/channels/1037340874172014652/1037343189339742298/1361811650713227285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311.
Description of Changes
This change makes it so that our internal join representation can take arbitrary query expressions for its right argument.
Previously only base table references were supported.
This is will allow pushing operations like index scans below joins.
API and ABI
If the API is breaking, please state below what will break