Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Aug 1, 2025

Description of Changes

A few of our new CI checks weren't set up to run in the merge queue, which prevented PRs from merging when those checks were marked required.

API and ABI breaking changes

None. CI only change.

Expected complexity level and risk

1

Testing

This will have to be tested by making these checks required again, and then seeing if this PR can merge.

@bfops bfops requested a review from jdetter August 1, 2025 17:04
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment

@bfops bfops added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@bfops bfops added this pull request to the merge queue Aug 1, 2025
Merged via the queue into master with commit f664a63 Aug 1, 2025
25 checks passed
@bfops bfops deleted the bfops/merge-group-ci branch August 19, 2025 21:07
mamcx pushed a commit that referenced this pull request Aug 26, 2025
# Description of Changes

A few of our new CI checks weren't set up to run in the merge queue,
which prevented PRs from merging when those checks were marked required.

# API and ABI breaking changes

None. CI only change.

# Expected complexity level and risk

1

# Testing

This will have to be tested by making these checks required again, and
then seeing if this PR can merge.

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants