Upgrade jemalloc_pprof and tempfile crates
#2982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run `cargo update` in CI before testing the bindings, in order to catch dependency issues for library users (which don't get dependency pinning via our `Cargo.lock` file). This turned up two issues, resolved here: - `jemalloc_pprof` depends on `pprof_util` both directly and indirectly via `mappings`. Using the `^0.7` version constraint causes conflicting versions of `pprof_util` to be resolved. Upgrade to `^0.8` to resolve the issue. - `tempfile` started to mark `TempDir::into_path` as deprecated in favor of the newly exported `TempDir::keep`, so bump to the latest version (recall that `3.20` is semver-compatible with `3.8`).
jsdt
approved these changes
Jul 24, 2025
Shubham8287
pushed a commit
that referenced
this pull request
Jul 28, 2025
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
cargo updatein CI before testing the bindings, in order tocatch dependency issues for library users (which don't get dependency
pinning via our
Cargo.lockfile).This turned up two issues, resolved here:
jemalloc_pprofdepends onpprof_utilboth directly and indirectlyvia
mappings. Using the^0.7version constraint causes conflictingversions of
pprof_utilto be resolved.Upgrade to
^0.8to resolve the issue.tempfilestarted to markTempDir::into_pathas deprecated in favorof the newly exported
TempDir::keep, so bump to the latest version(recall that
3.20is semver-compatible with3.8).Expected complexity level and risk
1
Testing