Addresses #2969 #2980
Merged
Addresses #2969 #2980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This seems fine but I'm not equipped to confirm whether this is correct, so I'm going to remove myself as a reviewer. (And it sounds like this PR is still essentially in progress). |
bfops
added
release-any
jsdt
approved these changes
Jul 31, 2025
Contributor
jsdt
left a comment
jsdt
left a comment
There was a problem hiding this comment.
I haven't set up a good way to run integration tests yet, but I manually tested that I the client can call a reducer that uses ScheduleAt in an argument, and it can query the rows from a schedule table.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
# Description of Changes We want to release #2980 for the TS SDK, so I'm bumping our version number. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing None, just a version bump. Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
# Description of Changes The `ScheduleAt` type appears to have an outdated structure. I've updated the structure of the `ScheduleAt` type represented in TypeScript to be in line with the Rust type: https://docs.rs/spacetimedb/latest/spacetimedb/enum.ScheduleAt.html Namely, we were missing the inner Spacetime library types of `TimeDuration` and `Timestamp`. This is to address #2969. # API and ABI breaking changes This is an API breaking change in that it changes the API, but it's breaking in that it fixes a bug. # Expected complexity level and risk 2 # Testing I have not done additional testing, but I thought I would get this PR started to make it easier for the next person who comes along. The ideal automated test to add would be one which connects a TypeScript client to a SpacetimeDB module with a scheduled table, and verifies that the type is correctly deserialized and represented in TypeScript when the rows are sent down. --------- Co-authored-by: Jeffrey Dallatezza <jeffreydallatezza@gmail.com>
bfops
added a commit
that referenced
this pull request
Aug 7, 2025
# Description of Changes We want to release #2980 for the TS SDK, so I'm bumping our version number. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing None, just a version bump. Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
# Description of Changes The `ScheduleAt` type appears to have an outdated structure. I've updated the structure of the `ScheduleAt` type represented in TypeScript to be in line with the Rust type: https://docs.rs/spacetimedb/latest/spacetimedb/enum.ScheduleAt.html Namely, we were missing the inner Spacetime library types of `TimeDuration` and `Timestamp`. This is to address #2969. # API and ABI breaking changes This is an API breaking change in that it changes the API, but it's breaking in that it fixes a bug. # Expected complexity level and risk 2 # Testing I have not done additional testing, but I thought I would get this PR started to make it easier for the next person who comes along. The ideal automated test to add would be one which connects a TypeScript client to a SpacetimeDB module with a scheduled table, and verifies that the type is correctly deserialized and represented in TypeScript when the rows are sent down. --------- Co-authored-by: Jeffrey Dallatezza <jeffreydallatezza@gmail.com>
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
# Description of Changes We want to release #2980 for the TS SDK, so I'm bumping our version number. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing None, just a version bump. Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The
ScheduleAttype appears to have an outdated structure. I've updated the structure of theScheduleAttype represented in TypeScript to be in line with the Rust type: https://docs.rs/spacetimedb/latest/spacetimedb/enum.ScheduleAt.htmlNamely, we were missing the inner Spacetime library types of
TimeDurationandTimestamp.This is to address #2969.
API and ABI breaking changes
This is an API breaking change in that it changes the API, but it's breaking in that it fixes a bug.
Expected complexity level and risk
2
Testing
I have not done additional testing, but I thought I would get this PR started to make it easier for the next person who comes along.
The ideal automated test to add would be one which connects a TypeScript client to a SpacetimeDB module with a scheduled table, and verifies that the type is correctly deserialized and represented in TypeScript when the rows are sent down.