ci: Skip the Unity tests if the PR is an external contribution #2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to leak the license information. Alternatively, we could just make the check non-required.
Collaborator
|
This seems reasonable to me. It would be ideal if we could still run these tests on external PRs, but since that doesn't seem to be an option, this is still better than what we do now! |
Contributor
Author
|
Mysteriously, the C# check is not running here nor in the test PR. |
bfops
approved these changes
Jul 24, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This makes sense to me and seems to have been tested!
Shubham8287
pushed a commit
that referenced
this pull request
Jul 28, 2025
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to leak the license information.
Alternatively, we could just make the check non-required.
Testing
Should test by submitting a PR from a fork.
I'll do that if / when we agree that this is the right approach.