smoketest: Retry if there is no current leader #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `wait_for_leader_change` helper, catch the case where `get_leader_info` doesn't return any rows, and retry. It is possible that no leader information exists when the node hosting the last leader is disconnected from the control db.
Shubham8287
approved these changes
Jul 21, 2025
Shubham8287
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
wait_for_leader_changehelper, catch the case whereget_leader_infodoesn't return any rows, and retry.It is possible that no leader information exists when the node hosting
the last leader is disconnected from the control db.
Expected complexity level and risk
1
Testing