Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Jul 16, 2025

Description of Changes

  • updated the CI files from sdks/typescript to run here
  • updated README.md and DEVELOP.md to reference SpacetimeDB instead of spacetimedb-typescript-SDK
  • left the release-related CI files in the old location so that they're properly mirrored (and run) in the spacetimedb-typescript-sdk repo

API and ABI breaking changes

None

Expected complexity level and risk

  1. It's possible I e.g. missed a working-directory invocation or didn't port something properly.

Testing

  • The new CI is running

@bfops bfops changed the title Fix up sdks/typescript/.github Fix up sdks/typescript GitHub files Jul 16, 2025
@bfops bfops requested a review from cloutiertyler July 16, 2025 14:43
@bfops bfops marked this pull request as ready for review July 16, 2025 14:43
Base automatically changed from bfops/import-typescript-sdk to master July 16, 2025 15:16
@bfops bfops requested a review from gefjon as a code owner July 16, 2025 15:17
@bfops bfops changed the title Fix up sdks/typescript GitHub files Fix up GitHub files related to TypeScript SDK Jul 16, 2025
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval on quickstart-chat module

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment.

@bfops bfops added this pull request to the merge queue Jul 16, 2025
Merged via the queue into master with commit cbba2b2 Jul 16, 2025
32 of 33 checks passed
@bfops bfops deleted the bfops/typescript-sdk-ci branch July 30, 2025 17:19
bfops added a commit that referenced this pull request Aug 7, 2025
Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
mamcx pushed a commit that referenced this pull request Aug 26, 2025
Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants