client-api: Send WebSocket messages fragmented#2931
Merged
Conversation
RFC 6455, Section 5.4 allows to send message fragmentation, and we can do that with tungstenite.
gefjon
reviewed
Jul 11, 2025
aasoni
reviewed
Nov 13, 2025
Contributor
aasoni
left a comment
aasoni
left a comment
There was a problem hiding this comment.
Tested this locally with BitCraft and had no issues loading into the game and playing for a few minutes.
aasoni
approved these changes
Dec 9, 2025
Contributor
aasoni
left a comment
aasoni
left a comment
There was a problem hiding this comment.
This was deployed to the BitCraft production cluster over a week ago and has not had issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6455, Section 5.4 describes message fragmentation, and we can do that with tungstenite.
It does seem to help getting control messages (ping, pong, close) through without head-of-line blocking.
Expected complexity level and risk
2 - Need to test with clients
Testing
TBD - some more abstraction is needed due to the difficulty of synthetically producing a large outgoing message.