refactor(sdk): improve the log message source line reference #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ResuBaka <ResuBaka@users.noreply.github.com>
gefjon
approved these changes
Aug 6, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
This seems eminently reasonable. My standards for comments are higher for macros than functions, so I've suggested one.
Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org> Signed-off-by: ResuBaka <ResuBaka@users.noreply.github.com>
Merged
via the queue into
clockworklabs:master
with commit Aug 7, 2025
1a5a03d
35 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently with the function maybe_log_error to log errors we hide the real source line where the error happened. So to still have the same logic but with more accurate source line, I moved it to a macro to have the same abstraction for logging.
API and ABI breaking changes
Expected complexity level and risk
1
Testing