Add V8Runtime skeleton + HostType::Js
#2923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/v8-host-skeleton
branch
from
623675e to
ce2ba55
Compare
kazimuth
reviewed
Jul 7, 2025
Centril
force-pushed
the
centril/v8-host-skeleton
branch
from
bc524d8 to
62da0f5
Compare
gefjon
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Extracts some of the work in #2839 that is mostly ceremony and not deeper V8 stuff. A
JsModuleis not constructible yet, so none of the panics are reachable.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
No testing yet. There's nothing interesting to test.