SATS: Move some method bodies to be provided in 'Serializer' instead #2921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/sats-ser-provided
branch
from
57db8fe to
8dca820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The methods
serialize_bsatn,serialize_bsatn_in_chunks, andserialize_str_in_chunksnow have provided bodies, removing some duplicated code in some impls ofSerializer.This is extracted from #2839 which provides a new
Serializerimpl.API and ABI breaking changes
None
Expected complexity level and risk
1 - just code motion.
Testing
This makes the testing situation better thanks to code sharing.
Other than that, this is covered by existing tests.