core: Allow caller to decide whether or not IRQ cores should be reserved #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the system is not configured to pin IRQ handling, or doesn't have enough cores, reserving those is wasteful. So let the caller choose. Also: - Make fields of `TokioCores` `pub`, needed to create an extra runtime - Re-export `CoreId`
kim
force-pushed
the
kim/core-pinning/irq-optional
branch
from
4f6c008 to
03e0289
Compare
joshua-spacetime
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the system is not configured to pin IRQ handling, or doesn't have
enough cores, reserving those is wasteful. So let the caller choose.
Also:
TokioCorespub, needed to create an extra runtimeCoreIdExpected complexity level and risk
1
Testing
It is advisable to use the pub
CoreReservations::applyto check that the poolallocations match expectations for the number of cores on the target system.