Record transaction metrics off the main thread #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Jun 30, 2025
bfops
added
release-any
joshua-spacetime
force-pushed
the
joshua/perf/move-metrics-off-reducer-thread
branch
from
7e454ac to
3bf0955
Compare
joshua-spacetime
force-pushed
the
joshua/perf/move-metrics-off-reducer-thread
branch
from
8a1e35c to
94412ec
Compare
Centril
approved these changes
Jul 1, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
This looks mostly good. There's some potential for confusion with other metrics workers that I'd like to disambiguate in the code by adding the prefix tx_ in various places as partially outlined below. Once those are addressed, this should be good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves the recording of transaction metrics off the main reducer thread, unblocking the next reducer.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Just a refactor. Existing test coverage still applies.