Fix query overwrites in the subscription manager #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/fix/subscription-overwrite
branch
from
a8426c9 to
34c7517
Compare
jdetter
approved these changes
Jun 26, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I thoroughly tested this using BitCraft and the target issue we were trying to address was gone when I upgraded to this patch. Additionally Joshua has added a regression test for this issue which was not passing before this PR but is passing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously if two clients subscribed to semantically equivalent but syntactically different queries, we could potentially overwrite one resulting in one of the clients not receiving updates for that query.
The fix was to update a type signature from
HashMap<_, QueryHash>toHashMap<_, Vec<QueryHash>>.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing