Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Jun 13, 2025

Description of Changes

Uses the database identity, not the owner identity, for subscription metrics. They are different. I incorrectly tagged these metrics with the owner identity in #2861.

API and ABI breaking changes

None

Expected complexity level and risk

0

Testing

@joshua-spacetime joshua-spacetime requested a review from mamcx June 13, 2025 23:40
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-spacetime joshua-spacetime added this pull request to the merge queue Jun 16, 2025
Merged via the queue into master with commit 27af02c Jun 16, 2025
21 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/use-db-identity-for-sub-metrics branch June 16, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants