Build indexes over TxData for subscription eval #2768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/perf/index-delta-tables
branch
from
c77584a to
44a790c
Compare
Centril
reviewed
May 22, 2025
joshua-spacetime
force-pushed
the
joshua/perf/index-delta-tables
branch
from
44a790c to
c569894
Compare
cloutiertyler
approved these changes
May 28, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Trait changes LGTM. No objection.
joshua-spacetime
force-pushed
the
joshua/perf/index-delta-tables
branch
3 times, most recently
from
df8663a to
6700d9c
Compare
joshua-spacetime
force-pushed
the
joshua/perf/index-delta-tables
branch
from
6700d9c to
40e09f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch builds indexes over
TxDatafor use in subscriptions.TxDatarepresents the row updates or delta tables. If a subscription uses an index on the corresponding physical table, we build the same index over the delta table. This means that for transactions that update a lot of rows, subscriptions no longer have to scan all of them just to find a single row. Instead they can do a direct index probe as if it were a physical table.API and ABI breaking changes
None
Expected complexity level and risk
3
Not particularly complex, but it did require updating some rewrite rules in the query planner.
Testing
This is a performance related refactor. It doesn't add any new functionality. Therefore all of the previous regression tests should apply.